runzhiwang commented on a change in pull request #230:
URL: https://github.com/apache/incubator-ratis/pull/230#discussion_r509891703



##########
File path: 
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -211,6 +219,17 @@ public void channelRead(ChannelHandlerContext ctx, Object 
msg) throws IOExceptio
 
         JavaUtils.allOf(remoteWrites).thenCombine(localWrite, (v, 
bytesWritten) -> {
               buf.release();
+              for (CompletableFuture<DataStreamReply> replyFuture : 
remoteWrites) {

Review comment:
       Please define another method to do this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to