amaliujia commented on a change in pull request #232:
URL: https://github.com/apache/incubator-ratis/pull/232#discussion_r512393398
##########
File path:
ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamReplyByteBuffer.java
##########
@@ -32,15 +33,16 @@
private final boolean success;
public DataStreamReplyByteBuffer(long streamId, long streamOffset,
ByteBuffer buffer,
- long bytesWritten, boolean success ) {
- super(streamId, streamOffset, buffer);
+ long bytesWritten, boolean success, Type type) {
+ super(streamId, streamOffset, buffer, type);
this.success = success;
this.bytesWritten = bytesWritten;
}
public DataStreamReplyByteBuffer(DataStreamReplyHeader header, ByteBuffer
buffer) {
- this(header.getStreamId(), header.getStreamOffset(), buffer,
header.getBytesWritten(), header.isSuccess());
+ this(header.getStreamId(), header.getStreamOffset(), buffer,
header.getBytesWritten(), header.isSuccess(),
+ header.getType());
Review comment:
is there a need to include type into replies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
