szetszwo commented on a change in pull request #233:
URL: https://github.com/apache/incubator-ratis/pull/233#discussion_r512489817



##########
File path: 
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -166,6 +181,11 @@ public void addRaftPeers(Collection<RaftPeer> newPeers) {
     }
   }
 
+  @VisibleForTesting
+  public CompletableFuture<RaftClientReply> 
submitClientRequestAsync(RaftClientRequest request) throws IOException {

Review comment:
       This is similar to GrpcService, which implements RaftServerRpc.  We may 
keep RaftServer internally and invokes RaftServer.submitClientRequestAsync() 
directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to