amaliujia commented on a change in pull request #234:
URL: https://github.com/apache/incubator-ratis/pull/234#discussion_r513946132
##########
File path:
ratis-common/src/main/java/org/apache/ratis/datastream/SupportedDataStreamType.java
##########
@@ -21,6 +21,7 @@
import org.apache.ratis.util.ReflectionUtils;
public enum SupportedDataStreamType implements DataStreamFactory {
+ DISABLED("org.apache.ratis.server.impl.DisabledDataStreamFactory"),
NETTY("org.apache.ratis.netty.NettyDataStreamFactory");
Review comment:
Because of dependencies.
`NettyDataStreamFactory` is in `ratis-netty`. A user who don't need stream
server, thus choose to disable steam server, should not depend on
`ratis-netty`.
Similarly, if in the future there is a `GrpcDataStreamFactory`, it likely
will be in `ratis-grpc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
