runzhiwang commented on a change in pull request #245:
URL: https://github.com/apache/incubator-ratis/pull/245#discussion_r515778358
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -80,42 +81,44 @@
*/
static class Proxies {
Review comment:
@amaliujia Please rebase master to use DataStreamOutput
stream(RaftGroupId groupId);
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -94,21 +95,21 @@ void addPeers(Collection<RaftPeer> newPeers) {
peers.addAll(newPeers);
}
- List<DataStreamOutput> getDataStreamOutput() throws IOException {
+ List<DataStreamOutput> getDataStreamOutput(RaftGroupId groupId) throws
IOException {
final List<DataStreamOutput> outs = new ArrayList<>();
try {
- getDataStreamOutput(outs);
+ getDataStreamOutput(outs, groupId);
} catch (IOException e) {
outs.forEach(CloseAsync::closeAsync);
throw e;
}
return outs;
}
- private void getDataStreamOutput(List<DataStreamOutput> outs) throws
IOException {
+ private void getDataStreamOutput(List<DataStreamOutput> outs, RaftGroupId
groupId) throws IOException {
Review comment:
@amaliujia Do you think can we merge these two getDataStreamOutput
method into one ?
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -94,21 +95,21 @@ void addPeers(Collection<RaftPeer> newPeers) {
peers.addAll(newPeers);
}
- List<DataStreamOutput> getDataStreamOutput() throws IOException {
+ List<DataStreamOutput> getDataStreamOutput(RaftGroupId groupId) throws
IOException {
final List<DataStreamOutput> outs = new ArrayList<>();
try {
- getDataStreamOutput(outs);
+ getDataStreamOutput(outs, groupId);
} catch (IOException e) {
outs.forEach(CloseAsync::closeAsync);
throw e;
}
return outs;
}
- private void getDataStreamOutput(List<DataStreamOutput> outs) throws
IOException {
+ private void getDataStreamOutput(List<DataStreamOutput> outs, RaftGroupId
groupId) throws IOException {
Review comment:
Okay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
