runzhiwang commented on a change in pull request #241:
URL: https://github.com/apache/incubator-ratis/pull/241#discussion_r517021344
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/PeerConfiguration.java
##########
@@ -94,6 +94,16 @@ boolean hasMajority(Collection<RaftPeerId> others,
RaftPeerId selfId) {
return num > size() / 2;
}
+ boolean majorityImpossibleWithout(Collection<RaftPeerId> rejected) {
Review comment:
Do you think rename majorityImpossibleWithout to majorityRejectVote
maybe better ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
