amaliujia commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520770461
##########
File path:
ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers)
throws Exception {
RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
RaftProperties properties = new RaftProperties();
NettyConfigKeys.DataStream.setPort(properties,
NetUtils.createLocalServerAddress().getPort());
+ RaftConfigKeys.DataStream.setType(properties,
SupportedDataStreamType.NETTY);
Review comment:
hmmm I see `RaftProperties properties = new RaftProperties();` is not
using the existing `properties`.
I will take a look and maybe fix this in my branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
