[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #272: RATIS-1130. Add E2E test for Ratis streaming based on MiniRaftCluster

Wed, 11 Nov 2020 23:38:23 -0800 


runzhiwang commented on a change in pull request #272:
URL: https://github.com/apache/incubator-ratis/pull/272#discussion_r521891899



##########
File path: 
ratis-netty/src/test/java/org/apache/ratis/netty/MiniRaftClusterWithNetty.java
##########
@@ -59,6 +74,7 @@ protected RaftServerProxy newRaftServer(
       RaftPeerId id, StateMachine.Registry stateMachineRegistry , RaftGroup 
group,
       RaftProperties properties) throws IOException {
     NettyConfigKeys.Server.setPort(properties, getPort(id, group));
+    NettyConfigKeys.DataStream.setPort(properties, getDataStreamPort(id, 
group));

Review comment:
       What's the relationship between this propertis and the propertis in the 
following code, why need setPort twice?
   
![image](https://user-images.githubusercontent.com/51938049/98909630-0be7d280-24fd-11eb-88bc-0e2c58ba4a14.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to