amaliujia commented on a change in pull request #272:
URL: https://github.com/apache/incubator-ratis/pull/272#discussion_r522541008
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -326,8 +327,11 @@ private StreamInfo newStreamInfo(ByteBuf buf) {
}
static long writeTo(ByteBuf buf, DataStream stream) {
- final WritableByteChannel channel = stream.getWritableByteChannel();
long byteWritten = 0;
+ if (stream == null) {
Review comment:
I will hold off if we need the `NULL` check for now because it is not
related to test itself.
Back to whether we need `MultiDataStreamStateMachine` for this
MiniRaftCluster test, here is my question:
If we enable `MultiDataStreamStateMachine` for MiniRaftCluster test, what is
the difference between this MiniRaftCluster test and the existing
`TestDataStreamNetty`? From the test coverage MiniRaftCluster will be a super
set over `TestDataStreamNetty`, why we want to keep both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
