amaliujia commented on a change in pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#discussion_r523238469
##########
File path:
ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -43,8 +43,8 @@
private final long seqNum;
private final CompletableFuture<DataStreamReply> replyFuture = new
CompletableFuture<>();
- DataStreamWindowRequest(long streamId, long offset, ByteBuffer data, long
seqNum, Type type){
- super(streamId, offset, data, type);
+ DataStreamWindowRequest(Type type, long streamId, long offset, ByteBuffer
data, long seqNum) {
Review comment:
Why choose to reorder parameters? if don't do so, this PR will be
smaller?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
