szetszwo commented on a change in pull request #278:
URL: https://github.com/apache/incubator-ratis/pull/278#discussion_r523704166
##########
File path:
ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamReplyByteBuffer.java
##########
@@ -83,6 +85,15 @@ public Builder setDataStreamPacket(DataStreamPacket packet) {
.setStreamOffset(packet.getStreamOffset());
}
+ public Builder setDataStreamException(DataStreamException exception) {
+ return setSuccess(false)
+
.setBuffer(DataStreamProtoUtils.exception2proto(exception).toByteString().asReadOnlyByteBuffer());
+ }
+
+ public Builder setThrowable(Throwable t) {
Review comment:
Agree. Let's wrap DataStreamException in RaftClientReply as your change
in #277. It looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
