amaliujia commented on a change in pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279#discussion_r523832837
##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -321,22 +321,11 @@ message NotReplicatedExceptionProto {
uint64 logIndex = 3;
}
-message StateMachineExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
-}
-
-message AlreadyClosedExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
-}
-
-message DataStreamExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
+message ThrowableProto {
+ string className = 1;
+ string errorMessage = 2;
+ bytes stackTrace = 3;
+ bytes cause = 4;
Review comment:
This is a good simplification 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
