runzhiwang commented on a change in pull request #275:
URL: https://github.com/apache/incubator-ratis/pull/275#discussion_r524849196
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
##########
@@ -346,6 +350,7 @@ public void close() {
LOG.warn(getId() + ": Failed to close " +
SupportedDataStreamType.NETTY + " server", ignored);
}
});
+ pauseMonitor.stop();
Review comment:
Do we need try catch ? so that close can continue when
pauseMonitor.stop() throw exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
