szetszwo commented on a change in pull request #300:
URL: https://github.com/apache/incubator-ratis/pull/300#discussion_r530717797



##########
File path: 
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -593,6 +593,30 @@ public boolean isLeaderReady() {
     return true;
   }
 
+  /**
+   * Return status of the RaftServer.
+   * @return LeaderStatus
+   */
+  public ServerStatus getServerStatus() {

Review comment:
       We already have isLeader() and isLeaderReady() covering all the cases.  
Could you use these two methods for now?  
   
   RaftServerImpl is an internal Ratis class but not a public API.  Ozone 
should not use it directly.  If there is a need, we should define a public API 
but not adding methods to RaftServerImpl.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to