runzhiwang commented on a change in pull request #308:
URL: https://github.com/apache/incubator-ratis/pull/308#discussion_r533333866
##########
File path:
ratis-test/src/test/java/org/apache/ratis/datastream/DataStreamTestUtils.java
##########
@@ -343,10 +343,8 @@ static void assertHeader(RaftServer server,
RaftClientRequest header, int dataSi
static void assertRaftClientMessage(RaftClientMessage expected, RaftPeerId
expectedServerId, RaftClientMessage computed) {
Assert.assertNotNull(computed);
- Assert.assertEquals(expected.getClientId(), computed.getClientId());
Review comment:
@szetszwo Thanks the suggestions. I have updated the patch.
As you find, if we expose primary's ClientId to user, the test looks
complicated. Besides, maybe we should not expose primary's ClientId to user,
it maybe confuse user, because user will find RaftClientReply's ClientId does
not match his RaftClient's ClientId. So maybe primary can convert
RaftClientReply of F to RaftClientReply of R again. what do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
