runzhiwang commented on a change in pull request #298:
URL: https://github.com/apache/incubator-ratis/pull/298#discussion_r534555533
##########
File path:
ratis-examples/src/main/java/org/apache/ratis/examples/filestore/FileStoreStateMachine.java
##########
@@ -40,14 +41,18 @@
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import
org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.util.FileUtils;
+import org.apache.ratis.util.JavaUtils;
import java.io.File;
import java.io.IOException;
import java.util.Objects;
import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
public class FileStoreStateMachine extends BaseStateMachine {
private final SimpleStateMachineStorage storage = new
SimpleStateMachineStorage();
+ private final ConcurrentMap<LogEntryProto, DataStream>
dataStreamToLogEntryMap = new ConcurrentHashMap<>();
Review comment:
Yes, I see the discussion. Because we have the path in the header,
dataStreamToLogEntryMap is never used, so I think we do not need it here, you
can add a comment in the link method. @szetszwo What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
