runzhiwang commented on a change in pull request #339:
URL: https://github.com/apache/incubator-ratis/pull/339#discussion_r539131795
##########
File path:
ratis-client/src/main/java/org/apache/ratis/client/api/DataStreamOutput.java
##########
@@ -28,7 +28,7 @@
import java.util.concurrent.CompletableFuture;
/** An asynchronous output stream supporting zero buffer copying. */
-public interface DataStreamOutput extends CloseAsync<DataStreamReply> {
Review comment:
@szetszwo Sorry, what should we do in closeAsync() ? Do we need to send
rpc call to primary ? If so, user maybe confused between writeAndCloseAsync
and closeAsync. I delete `extends CloseAsync` so that user can only close by
writeAndCloseAsync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
