amaliujia commented on a change in pull request #360:
URL: https://github.com/apache/incubator-ratis/pull/360#discussion_r545355909
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -568,6 +569,10 @@ private TermIndex shouldNotifyToInstallSnapshot() {
// should be notified to install the latest snapshot through its
// State Machine.
return getRaftLog().getTermIndex(leaderStartIndex);
+ } else if (leaderStartIndex == RaftLog.INVALID_LOG_INDEX) {
Review comment:
Just out of curiosity:
so leaderStartIndex == RaftLog.INVALID_LOG_INDEX means the leader has no log
at all (all have been purged) thus there is on valid start index?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]