runzhiwang commented on pull request #372: URL: https://github.com/apache/incubator-ratis/pull/372#issuecomment-749875466
@szetszwo hi, This is only draft, could you have a brief review ? 1. I did not include change priority in TransferLeaderShipRequest, I think change priority should be left to user, for example, there are 3 servers: server1, server2, server3, we want to transfer leadership from server1 to server2, we can assign server2 with highest priority, but we could not make sure whether server1's priority bigger or smaller than server3's priority, so I think this should be left to user to decide. When transferLeadership, I check whether server2 has the highest priority. 2. Not sure whether TimeoutScheduler is enough, if user pass a big value of timeout, such as 100 seconds, but transferLeadership finish in 1 second, we should not return to client after 100 seconds, so maybe we have to check periodically to return to client as soon as possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
