szetszwo commented on a change in pull request #373:
URL: https://github.com/apache/incubator-ratis/pull/373#discussion_r548817680
##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -113,6 +113,7 @@ message RaftRpcRequestProto {
RoutingTableProto routingTable = 14;
SlidingWindowEntry slidingWindowEntry = 15;
+ uint64 timeoutMs = 16;
Review comment:
Let's use 13, protobuf is more efficient when using field number <= 15.
See Assigning Field Numbers in
https://developers.google.com/protocol-buffers/docs/proto3
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
##########
@@ -619,7 +619,7 @@ RaftClientReply newExceptionReply(RaftClientRequest
request, RaftException excep
}
if (isWrite && isSteppingDown()) {
- final LeaderSteppingDownException lsde = new
LeaderSteppingDownException(getMemberId());
+ final LeaderSteppingDownException lsde = new
LeaderSteppingDownException(getMemberId() + " is in stepping down");
Review comment:
It should "is stepping down". The "in" should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
