amaliujia commented on a change in pull request #402:
URL: https://github.com/apache/incubator-ratis/pull/402#discussion_r564132141
##########
File path:
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -555,6 +555,16 @@ static TimeDuration leaderStepDownWaitTime(RaftProperties
properties) {
static void setLeaderStepDownWaitTime(RaftProperties properties,
TimeDuration noLeaderTimeout) {
setTimeDuration(properties::setTimeDuration,
LEADER_STEP_DOWN_WAIT_TIME_KEY, noLeaderTimeout);
}
+
+ String PRE_VOTE_KEY = PREFIX + ".pre-vote";
+ boolean PRE_VOTE_DEFAULT = true;
Review comment:
Nit: might be better to make this default value as `false` so downstream
applications (e.g. Ozone) won't feel surprising before benchmarking this
optimization.
##########
File path:
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -555,6 +555,16 @@ static TimeDuration leaderStepDownWaitTime(RaftProperties
properties) {
static void setLeaderStepDownWaitTime(RaftProperties properties,
TimeDuration noLeaderTimeout) {
setTimeDuration(properties::setTimeDuration,
LEADER_STEP_DOWN_WAIT_TIME_KEY, noLeaderTimeout);
}
+
+ String PRE_VOTE_KEY = PREFIX + ".pre-vote";
+ boolean PRE_VOTE_DEFAULT = true;
Review comment:
Sure we can start from `true` then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
