+1 binding - Built package from source - Unit tests passed (except TestRaftAsyncWithGrpc which is flaky) - Built Ozone using the RC artefacts - Verified checksums and signatures - LICENSE, NOTICE look ok
Thanks Aravindan. > On Oct 14, 2021, at 4:21 AM, Tsz Wo Sze <[email protected]> wrote: > > Hi Aravindan, > > Thanks for the info. I think it is fine to have the set-version commit > only in the tag. > > +1 > - Verified all checksums and signatures. > - Checked DISCLAIMER, LICENSE and NOTICE. > - Built from source successfully. > - Passed all unit tests although > TestRaftAsyncWithGrpc,TestRaftReconfigurationWithGrpc,TestRaftOutputStreamWithGrpc > are flaky. > > Tsz-Wo > > > On Wed, Oct 13, 2021 at 12:47 AM Aravindan Vijayan > <[email protected]> wrote: > >> Hello Nicholas, >> >> Thanks for taking a look at this. I referred the last Ratis release and >> found the commit to be present only in the *tag* ( >> >> https://github.com/apache/ratis/commit/8827573d2e66ec56ad94b219745fce98dd95c497 >> ), >> and not in the *branch*. Hence, I went with the same flow here. >> >> I believe that once an 'rc' is accepted, the release bits will be based >> off of a commit that belongs to the master branch. Since the version update >> commit has to go as the last one to the branch, the individual rc commits >> stay on the tag. Please let me know what you think. >> >> On Tue, Oct 12, 2021 at 7:34 AM Tsz Wo Sze <[email protected]> wrote: >> >>> Hi Aravindan, >>> >>> Thanks a lot for working on the release. >>> >>> Following from the provided rc0 tag [1] to the commit e1fd1cd [2], github >>> somehow said that "This commit does not belong to any branch on this >>> repository, and may belong to a fork outside of the repository." I also >>> tried to update my local git. The last commit was b98ff40 but not >>> e1fd1cd. The github webpage [3] and the gitbox webpage [4] also showed >>> b98ff40 as the last commit but not e1fd1cd. >>> >>> Somehow the commit e1fd1cd is missing. Could you take a look? >>> >>> Tsz-Wo >>> >>> [1] rc0 tag: >> https://github.com/apache/ratis/releases/tag/ratis-2.2.0-rc0 >>> [2] commit: >>> >>> >> https://github.com/apache/ratis/commit/e1fd1cdb39c6d12fdc8ad5d777bb1feef9962254 >>> [3] github webpage: https://github.com/apache/ratis ) and the >>> [4] gitbox webpage: >>> https://gitbox.apache.org/repos/asf?p=ratis.git;a=summary >>> >>> On Tue, Oct 12, 2021 at 11:51 AM jackson yao <[email protected]> >>> wrote: >>> >>>> +1, thanks for the work! >>>> >>>> Aravindan Vijayan <[email protected]> 于2021年10月12日周二 >>> 上午4:22写道： >>>> >>>>> Hello folks, >>>>> >>>>> Based on the previous discussion, I am calling a vote for Apache >> Ratis >>>>> Release >>>>> 2.2.0 rc0. >>>>> >>>>> The source and binary tarballs can be found at: >>>>> https://dist.apache.org/repos/dist/dev/ratis/2.2.0/rc0 >>>>> >>>>> Maven artifacts are staged at: >>>>> >>> https://repository.apache.org/content/repositories/orgapacheratis-1063/ >>>>> >>>>> The public key used for signing the artifacts can be found at: >>>>> https://dist.apache.org/repos/dist/dev/ratis/KEYS >>>>> >>>>> The fingerprint of key to sign release artifacts: >>>>> 652D 752A E080 F657 44F7 ED74 1576 B4E3 3ECA 3AAA >>>>> >>>>> The RC0 tag in github is at: >>>>> https://github.com/apache/ratis/releases/tag/ratis-2.2.0-rc0 >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> Starting with my +1 >>>>> -- >>>>> Thanks & Regards, >>>>> Aravindan >>>>> >>>> >>> >> >> >> -- >> Thanks & Regards, >> Aravindan >>
