Hi Yaolong,
Thanks a lot for working on the release! The following are a list of bug
fixes missing in rc2.
// work around a new gRPC memory leak
RATIS-1674. In GrpcLogAppender, disable retry and add minWait. (#752)
// Fix a corner in LogAppender
RATIS-1707. Fix corner case when getPrevious in LogAppenderBase (#745)
// A very simple CLI usage fix
RATIS-1713. Fix TakeSnapshotCommand's usage info (#753)
The first two are useful bug fixes and the third a minor message output
fix. All of them can be cleanly merged. How about we include them to
2.4.0?
Tsz-Wo
On Sat, Oct 1, 2022 at 5:22 PM William Song <[email protected]> wrote:
> Thanks Yaolong for working on release 2.4.0.
>
> +1 (non-binding)
> - Verified git commit hash
> - Built Ratis locally
> - Update Ratis in IoTDB and run CI.
>
> William
>
>
> > 2022年9月30日 16:07，刘尧龙 <[email protected]> 写道：
> >
> > Hi all,
> >
> >
> > After discussing and fixing a series of compatibility issues, I am
> calling
> > a vote for Apache Ratis Release 2.4.0 rc2.
> >
> >
> > The git tag to be voted upon:
> >
> >
> > https://github.com/apache/ratis/tree/ratis-2.4.0-rc2
> >
> >
> > The git commit hash:
> >
> >
> > 90001fa2d9cc0da24283ec2c506165a05f794e90
> >
> >
> > The source and binary tarballs can be found at:
> >
> >
> > https://dist.apache.org/repos/dist/dev/ratis/2.4.0/rc2
> >
> >
> > Fingerprint of the PGP key release artifacts are signed with:
> >
> >
> > 444D 29C9 DEEF A0E7 3D90 4BA5 2973 DD33 3371 E759
> >
> >
> > My public key to verify signatures can be found in:
> >
> >
> > https://dist.apache.org/repos/dist/dev/ratis/KEYS
> >
> >
> >
> > Maven artifacts are staged at:
> >
> >
> > https://repository.apache.org/content/repositories/orgapacheratis-1120/
> >
> >
> >
> > This vote will remain open for 7 days.
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove (and reason why)
> >
> >
> > Starting with my +1 (binding):
> >
> >
> > * Verified checksum, signature, git hash
> >
> > * Compared source tarball to repo at the given tag
> >
> > * Built from source
> >
> > * Ran regular Ratis CI [1]
> >
> >
> > Please vote on releasing this RC. Thank you in advance.
> >
> >
> > -Yaolong
> >
> >
> >
> > [1]
> https://github.com/codings-dan/incubator-ratis/actions/runs/3156930016
> > <https://github.com/codings-dan/incubator-ratis/actions/runs/3097852504>
>
>
