Hi Yaolong, When Sumit Agrawal worked on https://issues.apache.org/jira/browse/HDDS-7349 , he found that MetricRegistries has addReporterRegistration(..) but there is no method for removing the added metrics. This is not a problem in production but it could be a problem in unit tests.
He already has a patch in https://issues.apache.org/jira/browse/RATIS-1741 . How about we also merge it to branch-2? Tsz-Wo On Thu, Nov 10, 2022 at 6:03 AM Yaolong Liu <[email protected]> wrote: > Hi all, > > > I am calling a vote for Apache Ratis Release 2.4.1 rc0. > > > The git tag to be voted upon: > > > https://github.com/apache/ratis/tree/ratis-2.4.1-rc0 > > > The git commit hash: > > > 5b3989488704a9744a703d150b6e8a55ca87dc6d > > > The source and binary tarballs can be found at: > > > https://dist.apache.org/repos/dist/dev/ratis/2.4.1/rc0 > > > Fingerprint of the PGP key release artifacts are signed with: > > > 444D 29C9 DEEF A0E7 3D90 4BA5 2973 DD33 3371 E759 > > > My public key to verify signatures can be found in: > > > https://dist.apache.org/repos/dist/dev/ratis/KEYS > > > Maven artifacts are staged at: > > > https://repository.apache.org/content/repositories/orgapacheratis-1131/ > > > This vote will remain open for at least 72 hours. > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove (and reason why) > > > Starting with my +1 (binding): > > > * Verified checksum, signature, git hash > > > * Checked LICENSE and NOTICE > > > * Compared source tarball to repo at the given tag > > > * Built from source > > > * Ran regular Ratis CI [1] > > > Please vote on releasing this RC. Thank you in advance. > > > -Yaolong > > > > [1] https://github.com/codings-dan/incubator-ratis/actions/runs/3436848490 >
