> Could you update Alluxio to use the public API (ratis-server-api) instead > of the internal APIs?
Sure, thanks for providing the corrections. Kaijie On 2023/04/08 19:43:09 Tsz Wo Sze wrote: > Hi Kaijie, > > Could you update Alluxio to use the public API (ratis-server-api) instead > of the internal APIs? > > - getSmDir() -> storage.getStorageDir().getStateMachineDir() //storage > was passed from JournalStateMachine. > - loadLatestSnapshot() -> StateMachineStorage.getLatestSnapshot() > > Tsz-Wo > > > On Fri, Apr 7, 2023 at 12:38 AM Kaijie Chen <[email protected]> wrote: > > > Integration with Alluxio shows some unexpected API changes: > > Which was introduced by RATIS-1722 and RATIS-1723. > > > > Cc: Tsz-Wo Nicholas Sze > > > > --- > > build log: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile > > (default-compile) on project alluxio-core-server-common: Compilation > > failure: Compilation failure: > > [ERROR] > > /home/ckj/alluxio/core/server/common/src/main/java/alluxio/master/journal/raft/JournalStateMachine.java:[210,13] > > cannot find symbol > > [ERROR] symbol: method loadLatestSnapshot() > > [ERROR] location: variable mStorage of type > > org.apache.ratis.statemachine.impl.SimpleStateMachineStorage > > [ERROR] > > /home/ckj/alluxio/core/server/common/src/main/java/alluxio/master/journal/raft/JournalStateMachine.java:[637,17] > > cannot find symbol > > [ERROR] symbol: method loadLatestSnapshot() > > [ERROR] location: variable mStorage of type > > org.apache.ratis.statemachine.impl.SimpleStateMachineStorage > > [ERROR] > > /home/ckj/alluxio/core/server/common/src/main/java/alluxio/master/journal/raft/SnapshotReplicationManager.java:[472,17] > > cannot find symbol > > [ERROR] symbol: method loadLatestSnapshot() > > [ERROR] location: variable mStorage of type > > org.apache.ratis.statemachine.impl.SimpleStateMachineStorage > > [ERROR] > > /home/ckj/alluxio/core/server/common/src/main/java/alluxio/master/journal/raft/RaftJournalUtils.java:[71,36] > > cannot find symbol > > [ERROR] symbol: method getSmDir() > > [ERROR] location: variable storage of type > > org.apache.ratis.statemachine.impl.SimpleStateMachineStorage > > > > On 2023/04/05 08:46:23 Xiangpeng Hu wrote: > > > Thanks William for working on rc1! > > > +1(non-binding) > > > > > > > > > * Verified all checksums and signatures > > > * Built Ratis from source > > > * Run loTDB CI using Ratis 2.5.0 rc1 > > > > > > > > > | > > > Xiangpeng Hu > > > | > > > ---- Replied Message ---- > > > | From | William Song<[email protected]> | > > > | Date | 4/4/2023 20:27 | > > > | To | <[email protected]> | > > > | Subject | [VOTE] Apache Ratis Release 2.5.0 rc1 | > > > Hi Ratis community, > > > > > > I’m calling a vote For Apache Ratis Release 2.5.0 rc1. > > > > > > The git tag to be vote upon: > > > https://github.com/apache/ratis/tree/ratis-2.5.0-rc1 > > > > > > The git commit hash: > > > c37d76b7171d75b9a07066d199fb2d69050e3ff4 > > > > > > The source and binary tarballs can be found at: > > > https://dist.apache.org/repos/dist/dev/ratis/2.5.0/rc1/ > > > > > > Fingerprint of the GPG key release artifacts are signed with: > > > DCE2 C33D 41C6 2578 969D BAFE 37D6 ECF8 4E78 BC92 > > > > > > My public key to verify signatures can be found in: > > > https://dist.apache.org/repos/dist/dev/ratis/KEYS > > > > > > Maven artifacts are staged at: > > > https://repository.apache.org/content/repositories/orgapacheratis-1138 > > > > > > > > This vote will remain open for at least 72 hours. > > > Please vote on releasing this ratis-2.5.0-rc1. Thanks in advance. > > > > > > [ ] +1 approve > > > [ ] 0 no opinion > > > [ ] -1 disapprove (and reason why) > > > > > > Starting with my +1(binding) > > > - Verified checksums, signatures and git hash. > > > - Checked LICENSE and NOTICE. > > > - Compared the files in src tarball with the files at the given git tag. > > > - Built from source. > > > - Ran regular Ratis CI. [1] > > > > > > [1] https://github.com/apache/ratis/actions/runs/4607311450 > > >
