+1 - Verified all checksums and signatures. - Checked LICENSE and NOTICE. - Compared the files in the src tarball with the files in git. - Built from source successfully. - Passed all unit tests. - Able to run examples and shell with the bin tarball
TestNettyDataStreamStarTopologyWithGrpcCluster had failed with some Jvm pauses. It passed once the Xmx value had been increased. Tsz-Wo On Tue, May 2, 2023 at 7:52 AM William Song <[email protected]> wrote: > +1 (binding) > > - Verified checksums, signatures and git hash > - Compared source tarball with to repo at the given tag > - Built from source > - Ran Ratis CI locally > - Ran IoTDB CI with staged jars locally > > Thanks, > William > > > 2023年4月28日 04:17,Attila Doroszlai <[email protected]> 写道: > > > > Hi all, > > > > I am calling a vote for Apache Ratis Release 2.5.1 rc1. > > > > Changes on top of 2.5.0: > > * a96bfeeb RATIS-1838. Compare commit index with last included index > > when installSnapshot > > * 05410aaf RATIS-1837. Restrict reading maxChunkSize bytes each > > installSnapshot RPC > > * 262e8cb5 RATIS-1834. ServerRequestStreamObserver is not properly closed > > * b221e622 RATIS-1835. Keep nextIndex unchanged when leader sending > > heartbeat to restarting followers > > * c12c3c9b RATIS-1831. GrpcLogAppender spinning idle between heartbeats > > > > The git tag to be voted upon: > > https://github.com/apache/ratis/tree/ratis-2.5.1-rc1 > > > > The git commit hash: > > 77640a3a1d012d0225d26a5a52b38fb80bb9fe44 > > > > The source and binary tarballs can be found at: > > https://dist.apache.org/repos/dist/dev/ratis/2.5.1/rc1 > > > > Fingerprint of the PGP key release artifacts are signed with: > > 0949 35E7 9D62 A9C4 A969 CCE2 B629 7DE9 82CF 1F4E > > > > My public key to verify signatures can be found in: > > https://dist.apache.org/repos/dist/release/ratis/KEYS > > > > Maven artifacts are staged at: > > https://repository.apache.org/content/repositories/orgapacheratis-1140/ > > > > This vote will remain open for 7 days. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Starting with my +1 (binding): > > > > * Verified checksum, signature, git hash > > * Compared source tarball to repo at the given tag > > * Ran Rat check on source > > * Built from source > > * Ran regular Ozone CI using the staged jars [1] (passed except some > > flaky tests) > > > > Please vote on releasing this RC. Thank you in advance. > > > > -Attila > > > > [1] https://github.com/adoroszlai/hadoop-ozone/actions/runs/4823290063 > >
