Hi Xinyu, RATIS-2325 is a kind of a new feature. Due to the previous gRPC issue discovered, it probably should NOT be included in a maintenance release.
RATIS-2350 seems a test issue -- TestReadOnlyRequestWithGrpc is testing different confs (DEFAULT, LINEARIZABLE and LeaderLease) at the same time. It seems the conf may not be set/reset correctly. I am going to take a look in more details. Please see if you like to wait for it. Tsz-Wo On Mon, Nov 3, 2025 at 10:10 PM Xinyu Tan <[email protected]> wrote: > Hi, Tsz-Wo > > Maybe we need to wait for the RATIS-2325 and RATIS-2350 in rc4? > > Best > -------------- > Xinyu Tan > > On 2025/11/03 05:31:39 Tsz Wo Sze wrote: > > Hi Xinyu, > > > > All (1), (2) and (3) are merged now. In addition, we also have > > merged RATIS-2349. Let's also include it? > > > > BTW, I tested the current master with ratis-shell and ratis-examples. It > > worked fine and all the previous problems disappeared. > > > > Tsz-Wo > > > > > > On Sun, Nov 2, 2025 at 12:15 AM Xinyu Tan <[email protected]> wrote: > > > > > Hi, Tsz Wo > > > > > > Thanks for the detailed findings! Let's fix them all and roll a rc4 > then. > > > > > > BTW, this pr(https://github.com/apache/ratis/pull/1303) can be > included > > > in rc4 too. > > > > > > Best > > > ----------------- > > > Xinyu Tan > > > > > > On 2025/10/31 18:19:38 Tsz Wo Sze wrote: > > > > > (1) RATIS-2347: NPE in GrpcServerProtocolService ... > > > > > > > > The PR is available: https://github.com/apache/ratis/pull/1304 > > > > > > > > > (2) gRPC prints the following warnings. ... > > > > > > > > It is caused by RATIS-2325. "Create GrpcStubPool for > > > > GrpcServerProtocolClient (#1283)". The warnings disappear without > > > > RATIS-2325. I guess we should revert it. > > > > > > > > One more issue: > > > > (3) RATIS-2348: When the StateMachine fails to > > > > handle InstallSnapshotNotification, GrpcLogAppender can print a lot > of > > > > messages. > > > > > > > > The PR is available: https://github.com/apache/ratis/pull/1305 > > > > > > > > Tsz-Wo > > > > > > > > > > > > On Fri, Oct 31, 2025 at 9:17 AM Tsz Wo Sze <[email protected]> > wrote: > > > > > > > > > Hi Xinyu, > > > > > > > > > > Found two problems this time: > > > > > > > > > > (1) RATIS-2347: NPE in GrpcServerProtocolService. It is annoying > > > message > > > > > that should be fixed, although it seems won't cause any real > problems > > > since > > > > > the NPE is caught in TimeoutTimer, the timeout task is scheduled by > > > > > BatchLogger. > > > > > > > > > > (2) gRPC prints the following warnings. It may be related to my > > > > > network/machine. Will see if it can be reproduced. > > > > > > > > > > Oct 30, 2025 11:15:51 AM > > > > > org.apache.ratis.thirdparty.io.grpc.netty.NettyClientHandler$3 > > > > > onGoAwayReceived > > > > > WARNING: Received GOAWAY with ENHANCE_YOUR_CALM. Debug data: > > > too_many_pings > > > > > Oct 30, 2025 11:15:51 AM > > > > > org.apache.ratis.thirdparty.io.grpc.netty.NettyClientHandler$3 > > > > > onGoAwayReceived > > > > > WARNING: Received GOAWAY with ENHANCE_YOUR_CALM. Debug data: > > > too_many_pings > > > > > Oct 30, 2025 11:15:51 AM > > > > > org.apache.ratis.thirdparty.io.grpc.netty.NettyClientHandler$3 > > > > > onGoAwayReceived > > > > > WARNING: Received GOAWAY with ENHANCE_YOUR_CALM. Debug data: > > > too_many_pings > > > > > Oct 30, 2025 11:15:51 AM > > > > > org.apache.ratis.thirdparty.io.grpc.netty.NettyClientHandler$3 > > > > > onGoAwayReceived > > > > > WARNING: Received GOAWAY with ENHANCE_YOUR_CALM. Debug data: > > > too_many_pings > > > > > Oct 30, 2025 11:15:51 AM > > > > > org.apache.ratis.thirdparty.io.grpc.internal.AtomicBackoff$State > > > backoff > > > > > WARNING: Increased keepalive time nanos to 60,000,000,000 > > > > > > > > > > > > > > > Tsz-Wo > > > > > > > > > > On Sun, Oct 26, 2025 at 9:13 AM Xinyu Tan <[email protected]> > wrote: > > > > > > > > > >> Hi Ratis community, > > > > >> > > > > >> I’m calling a vote For Apache Ratis Release 3.2.1 rc3. > > > > >> > > > > >> The git tag to be vote upon: > > > > >> https://github.com/apache/ratis/tree/ratis-3.2.1-rc3 > > > > >> > > > > >> The git commit hash: > > > > >> 5044a9f6da01f21fa23c0f04edfd42b6e77b7502 > > > > >> > > > > >> The source and binary tarballs can be found at: > > > > >> https://dist.apache.org/repos/dist/dev/ratis/3.2.1/rc3 > > > > >> > > > > >> Fingerprint of the GPG key release artifacts are signed with: > > > > >> 055D2E860E43CBB155D09AA4BECD7978EE4DA7BC > > > > >> > > > > >> My public key to verify signatures can be found in: > > > > >> https://dist.apache.org/repos/dist/release/ratis/KEYS > > > > >> > > > > >> Maven artifacts are staged at: > > > > >> > > > https://repository.apache.org/content/repositories/orgapacheratis-1172 > > > > >> > > > > >> This vote will remain open for at least 7 days. > > > > >> Please vote on releasing this ratis-3.2.1-rc3. Thanks in advance. > > > > >> > > > > >> [ ] +1 approve > > > > >> [ ] 0 no opinion > > > > >> [ ] -1 disapprove (and reason why) > > > > >> > > > > >> Starting with my +1 > > > > >> - Verified checksums, signatures and git hash. > > > > >> - Checked LICENSE and NOTICE. > > > > >> - Compared the files in src tarball with the files at the given > git > > > tag. > > > > >> - Built from source. > > > > >> - Ran regular Ratis CI. [1] > > > > >> > > > > >> [1] https://github.com/apache/ratis/actions/runs/18820211929 > > > > >> > > > > > > > > > > > > > > >
