Jakob, Thanks for the comments. For the unit tests, Jing just have filed RATIS-85 for fixing them.
For "mvn package", I just have tried it but it did not fail by RAT without a header for dependency-reduced-pom.xml. Are you sure that the command is "mvn package"? Anyway, you might have noticed that dependency-reduced-pom.xml is a generated file so that it does not need a license header. Tsz-Wo On Wed, May 3, 2017 at 12:26 PM, Jakob Homan <[email protected]> wrote: > +1 (binding) > > * Verified sigs on tar ball. > * Disclaimer/License/Notice look good > * Headers look good > > Concerns: > * Unit tests hang/fail. TestNotLeaderExceptionWithHadoopRpc fails > immediately and then TestRaftReconfigurationWithHadoopRpc hangs for at > least five minutes (canceled after that). Any reason these shouldn't > succeed? > * mvn package fails: > ratis-0.1.0-alpha/ratis-proto-shaded/dependency-reduced-pom.xml gets > caught up by RAT without a header. > > These nits can be addressed in the next release. > > -Jakob > > > On 3 May 2017 at 11:40, Jitendra Pandey <[email protected]> wrote: >> Downloaded the tar ball, verified the signatures. >> >> +1 >> >> On 5/3/17, 11:29 AM, "Jing Zhao" <[email protected]> wrote: >> >> +1. Thanks for driving this, Nicholas! >> >> On Tue, May 2, 2017 at 7:51 PM, Tsz Wo Sze <[email protected]> wrote: >> >> > Hi Apache Ratis PPMC, >> > >> > I am calling a vote for Apache Ratis incubating Release 0.1.0-alpha >> rc0. >> > >> > The git tag to be voted upon: >> > https://git-wip-us.apache.org/repos/asf?p=incubator-ratis. >> > git;a=shortlog;h=refs/tags/ratis-0.1.0-alpha >> > >> > The git commit hash: >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h= >> > 52c4b6412df7daba82445db289f7b41e2216b4a6 >> > >> > The source tarball can be found at: >> > https://dist.apache.org/repos/dist/dev/incubator/ratis/0.1.0-alpha/rc0/ >> > >> > The fingerprint of key to sign release artifacts: >> > 2C33 A9CB 66AE AD59 3183 B01B 7843 4EF4 60D6 914B >> > >> > Release artifacts are signed with one of the keys available at: >> > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS >> > >> > This vote will remain open for at least 72 hours. >> > Please vote on releasing this RC. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove (and reason why) >> > >> > Obviously, I am +1. >> > >> > Regards, >> > Tsz-Wo >> > >> >>
