Hi Vinay,
These are all good points, and suggested improvements make sense as well.
I would suggest starting with small actionable jiras where you can provide a
quick patch, so that you familiarize with our dev process, and build momentum
as patches are committed.
For example, (3) seems like a good start.
(4) is certainly worth investigating, as it seems like a potential memory
leak. For other improvements as well, please feel free to file jiras, and
provide patches.
jitendra
On 4/3/18, 8:27 PM, "Vinay Banakar" <[email protected]> wrote:
Hello
Here are a few issues/features that I think requires some attention other
than the ones tracked in Jira already:
1. Overall project design document is missing. [Which would help early
adopters/contributors to pick up the pace]
2. I can see that there are nice scripts that [
/ratis-examples/src/main/bin] does some operations [Start, assign, get]
in the arithmetic-example, however
1. Clearly we can add more functionality to it, like “append” =>
./client.sh append –name b –value 5 [Which appends requesting
value to it].
Or we can handle this here ./client.sh assign –name b –value b+5
[Today this throws an exception].
2. Also another important operation can be “remove/delete”, where we
can remove/delete an assigned name from the cluster. This would
provide a
truly succinct example for those using it in the future.
3. Handle Error exception for ./client.sh get –name “Unassigned
variable” and terminate operation.
4. Performance investigation: I have a Windows VM with 8Gb RAM and
enough disk space, yet when the Arithmetic-example runs for a prolonged
period (for about 2-3 hrs) even with no client operations, it is taking
up
huge memory space and causing memory crunch for other operations. Has
anyone experienced this before? Should this be investigated further.
Should I file these as new features/issues in Jira?
Do you have any comments on these?
Thank you
Best
Vinay Banakar
