+1 (binding) * LICENSE and NOTICE look good * Sig matches from the KEYs file * Package naming looks good * Licenses appear good, but it can be tricky to tell because of the code that's included in the ratis-proto-shaded directory (for example, ratis-proto-shaded/src/main/java/org/apache/ratis/shaded/org/jctools/queues/atomic/LinkedAtomicArrayQueueUtil.java). This code has no included license header but is documented in the LICENSE file. * Directory structure looks good
Nit: * NOTICE: Copyright year is still 2017 Note 1: I can't get the code to compile, but I think it's something on my side. With Sun JDK 1.8.0_60/Maven 3.5.3/OSX, it compiles ratis protoshaded for like five minutes before spitting out a bunch of "sun.misc.Unsafe is internal proprietary API and may be removed in a future release" warnings that Maven then converts to errors and fails. I can't see anything in the discussion list for this. This happens when running package, compile, etc. Note 1: I didn't look at the bin archive since it's not technically part of the release. On 7 May 2018 at 15:59, Tsz Wo Sze <szets...@gmail.com> wrote: > Marton, > > I compared you keys in two locations below > - https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS > - > http://pgp.mit.edu/pks/lookup?op=get&fingerprint=on&search=0x78434EF460D6914B > > They somehow look different. They match until "Zz6JA". Do you know why? > > Tsz-Wo > > On Sun, May 6, 2018 at 3:57 AM, Elek, Marton <e...@apache.org> wrote: >> >> Hi all, >> >> I'd like to call a vote to release Apache Ratis (incubating) 0.2.0. >> >> This is the second incubator release and it includes more than 120 >> improvements and fixes since the previous 0.1.0-alpha release. This is the >> first release >> which includes a binary package with ready to use example project. >> >> All distribution packages, including signatures, digests, etc. can be >> found at: >> >> https://dist.apache.org/repos/dist/dev/incubator/ratis/0.2.0/rc0/ >> >> Staged artifacts can be found at: >> >> https://repository.apache.org/content/repositories/orgapacheratis-1003/ >> >> >> This release has been signed with PGP key 0EE79B28, corresponding to >> e...@apache.org, which is included in the repository's KEYS file >> (https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS). >> >> This key can be found on keyservers, such as: >> >> http://pgp.mit.edu/pks/lookup?op=get&search=0x0EE79B28 >> >> Or in the apache phonebook: >> >> https://people.apache.org/keys/committer/elek.asc >> >> >> The release candidate has been tagged in git with ratis-0.2.0-rc0 (ee4936d) >> >> https://github.com/apache/incubator-ratis/releases/tag/ratis-0.2.0-rc0 >> >> >> >> Please review and vote. The vote will be open for at least 72 hours. >> >> If the vote passed, the second stage vote will be called on the Apache >> incubator mailing list to get approval from the Incubator PMC. >> >> >> >> # Review/testing >> >> You can check the usual requirements of an apache release: >> >> • Signatures >> • Checksums >> • License and notice files >> • Disclaimer file (incubator!) >> • Build the project from the source code package (mvn clean install >> assembly:single -DskipTests=true ) >> • Licence headers >> >> The binary papckage can be smoketested with: >> >> ./examples/bin/start-all.sh >> ./examples/bin/client.sh assign --name a --value 2 >> ./examples/bin/client.sh get --name a >> >> >> >> Starting with my vote: +1 >> >> Thanks, >> Marton
