Github user andy2git commented on a diff in the pull request:
https://github.com/apache/incubator-ratis/pull/2#discussion_r190361776
--- Diff:
ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java
---
@@ -104,7 +104,7 @@ public SingleFileSnapshotInfo findLatestSnapshot()
throws IOException {
Files.newDirectoryStream(smDir.toPath())) {
for (Path path : stream) {
Matcher matcher =
SNAPSHOT_REGEX.matcher(path.getFileName().toString());
- if (matcher.matches()) {
+ if (matcher.matches() &&
MD5FileUtil.existDigestFile(path.toFile())) {
--- End diff --
One concern I have is: do we need to delete the maybe corrupted snapshot
file? If we do not purge logs, we can always replay from the commit logs.
---
