Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/incubator-ratis/pull/4#discussion_r214453065
  
    --- Diff: 
ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStreamConfiguration.java
 ---
    @@ -0,0 +1,47 @@
    +package org.apache.ratis.logservice.api;
    +
    +import java.util.Map;
    +import java.util.Map.Entry;
    +
    +/**
    + * An encapsulation of configuration for a LogStream.
    + */
    +public interface LogStreamConfiguration {
    --- End diff --
    
    I definitely don't want to reuse Hadoop's Configuration because 
hadoop-common pulls in tons of crap we don't want or need just to reuse 
Configuration. Ratis does have the notion of configuration, but I see this 
object sitting on top of that. The RaftClient has configuration controls how 
that would be set up, but the LogService would have more on top of that.
    
    My goal was to just keep this as minimal as possible and only using 
JRE-provided classes until we have a better idea of how we'll use the 
configuration.


---

Reply via email to