andy2git commented on a change in pull request #17: RATIS-243 purge commit logs
after persisting snapshots
URL: https://github.com/apache/incubator-ratis/pull/17#discussion_r275618071
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/storage/RaftLog.java
##########
@@ -314,6 +314,15 @@ void validateLogEntry(LogEntryProto entry) {
abstract CompletableFuture<Long> truncateImpl(long index);
+
+ @Override
+ public final CompletableFuture<Long> purge(long index) {
+ return runner.runSequentially(() -> purgeImpl(index));
Review comment:
@szetszwo was wondering if need to run sequentially here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
