ankitsinghal commented on a change in pull request #18: RATIS-523 RATIS-524
RATIS-525 RATIS-526 RATIS-527 RATIS-533 Lots of cleanup on the LogService
URL: https://github.com/apache/incubator-ratis/pull/18#discussion_r280301394
##########
File path:
ratis-logservice/src/main/java/org/apache/ratis/logservice/server/LogServer.java
##########
@@ -61,13 +64,31 @@ public static Builder newBuilder() {
return new Builder();
}
+ @Override
+ void setRaftProperties(RaftProperties properties) {
+ super.setRaftProperties(properties);
+
+ // Increase the client timeout
+ RaftClientConfigKeys.Rpc.setRequestTimeout(properties,
TimeDuration.valueOf(100, TimeUnit.SECONDS));
+
+ // Increase the segment size to avoid rolling so quickly
+ SizeInBytes segmentSize = SizeInBytes.valueOf("32MB");
Review comment:
why hardcoding? can't we do it through some config? or it is just default
and will be overridden in later step?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
