joshelser commented on a change in pull request #25: RATIS-588 LogStream
StateMachine export
URL: https://github.com/apache/incubator-ratis/pull/25#discussion_r294465531
##########
File path:
ratis-logservice/src/test/java/org/apache/ratis/logservice/LogServiceReadWriteBase.java
##########
@@ -166,6 +174,37 @@ public void testLogServiceReadWrite() throws Exception {
assertEquals(expected, actual);
}
testJMXMetrics(logStream);
+ assertEquals(logStream.getState(),State.OPEN);
+
+ //In absense of MetaStateMachine, calling raft directly
Review comment:
This is a nice test!
Would it be good to make a new unit test which does have both metadata and
logserver quorums?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
