+1 -- Built from the source - OK -- Hashes and Signatures[5] - OK -- Ran unit tests - All passed -- Ran rat check on the source - OK
Some comments:- * NOTICE[1] assembled in a binary tar doesn't include a NOTICE[2] from the project. * NOTICE[1] doesn't look exhaustive (eg:- No mention of Junit dependency "Eclipse Public License 1.0") under Could also use a supplemental model[4] for dependencies which have incomplete information about their NOTICE/LICENSE * same with LICENSE[3], for eg:- no mention of "Eclipse Public License - v 1.0"[4] [1] http://people.apache.org/~msingh/0.4.0-rc1/apache-ratis-incubating-0.4.0-rc1-bin.tar.gz [2] https://github.com/apache/incubator-ratis/blob/master/NOTICE [3] http://people.apache.org/~msingh/0.4.0-rc1/apache-ratis-incubating-0.4.0-rc1-bin.tar.gz [4] https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html [5] https://dist.apache.org/repos/dist/release/incubator/ratis/KEYS Regards, Ankit Singhal On Thu, Aug 1, 2019 at 11:02 AM Uma gangumalla <umamah...@apache.org> wrote: > +1 (binding) > > built from source > LICENCE and NOTICE files looks good. > Sig and hashes are fine > > Few test timeouts[1] came in my 'mvn clean install'. Probably that's only > to me as others might already ran tests and +1ed. ( Should not be a blocker > I guess, if they are passing with others env) > > Regards, > Uma > > [1] > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] > > TestRaftSnapshotWithGrpc>RaftSnapshotBaseTest.testBasicInstallSnapshot:220->RaftSnapshotBaseTest.assertLeaderContent:78 > [ERROR] > > TestRaftReconfigurationWithNetty>RaftReconfigurationBaseTest.testReconfTwice:140->RaftReconfigurationBaseTest.runTestReconfTwice:192->RaftReconfigurationBaseTest.lambda$runTestReconfTwice$5:200 > s3: ConfigurationManager, init=-1: [s0:0.0.0.0:50941, s1:0.0.0.0:45664, > s2: > 0.0.0.0:49625], old=null, confs={ > 0 -> 0: [s0:0.0.0.0:50941, s1:0.0.0.0:45664, s2:0.0.0.0:49625], old=null > 41 -> 41: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1: > 0.0.0.0:45664, s2:0.0.0.0:49625], old=[s0:0.0.0.0:50941, s1:0.0.0.0:45664, > s2:0.0.0.0:49625] > 43 -> 43: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1: > 0.0.0.0:45664, s2:0.0.0.0:49625], old=null > 45 -> 45: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625], > old=[s3: > 0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1:0.0.0.0:45664, s2: > 0.0.0.0:49625] > 47 -> 47: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625], > old=null > 49 -> 49: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625], > old=null > 50 -> 50: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625], > old=null > } expected:<7> but was:<8> > [ERROR] > > TestRaftSnapshotWithNetty>RaftSnapshotBaseTest.testRestartPeer:146->RaftSnapshotBaseTest.assertLeaderContent:78 > [ERROR] > > TestRaftLogMetrics.testFlushMetric:78->runTestFlushMetric:93->assertFlushCount:110 > expected:<5> but was:<4> > [ERROR] > > TestRaftSnapshotWithSimulatedRpc>RaftSnapshotBaseTest.testBasicInstallSnapshot:220->RaftSnapshotBaseTest.assertLeaderContent:78 > [ERROR] Errors: > [ERROR] > > TestRaftReconfigurationWithGrpc>RaftReconfigurationBaseTest.testReconfTimeout:207->RaftReconfigurationBaseTest.runTestReconfTimeout:217 > » NullPointer > [ERROR] > > TestRequestLimitAsyncWithGrpc>RequestLimitAsyncBaseTest.testWriteElementLimit:65->RequestLimitAsyncBaseTest.runTestWriteElementLimit:119->BaseTest.getWithDefaultTimeout:168 > » Timeout > [ERROR] > > TestRaftStateMachineExceptionWithNetty>RaftStateMachineExceptionTests.testRetryOnExceptionDuringReplication:177 > » NullPointer > [ERROR] > > TestRaftStateMachineExceptionWithSimulatedRpc>RaftStateMachineExceptionTests.testRetryOnExceptionDuringReplication:177 > » NullPointer > [INFO] > [ERROR] Tests run: 241, Failures: 5, Errors: 4, Skipped: 4 > > On Mon, Jul 29, 2019 at 2:59 AM Mukul Kumar Singh < > mksingh.apa...@gmail.com> > wrote: > > > Hi Apache Ratis PPMC, > > > > I am calling a vote for Apache Ratis incubating Release 0.4.0 rc1. > > This vote is after fixing issues RATIS-642 & RATIS-621 in the rc0 vote. > > > > This is with respect to the discuss mailthread < > > > https://lists.apache.org/thread.html/781fb6db8fe3327683f96b880496cf4b297f8666a2fab85c413c6f4b@%3Cdev.ratis.apache.org%3E > > >. > > > > The git tag to be voted upon: > > > > > https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=shortlog;h=refs/tags/0.4.0-rc1 > > > > The git commit hash: > > > > > https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=5dc4e717c8540b275cc2af33ab100c2a6ec21fc2 > > < > > > https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=d4f5c9ded9ea4dc1a8acbec9a5e24f5e2f3bc6b6 > > > > > > > The source and binary tarballs can be found at: > > http://people.apache.org/~msingh/0.4.0-rc1/ < > > http://people.apache.org/~msingh/0.4.0-rc0/> > > > > The fingerprint of key to sign release artifacts: > > 45B0 13F6 29C6 89CC 6EE3 77B0 8D43 C3D9 A8F1 02BD > > > > Release artifacts are signed with one of the keys available at: > > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS < > > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS> > > > > This vote will remain open for at least 72 hours. > > Please vote on releasing this RC. Thank you in advance. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Starting with my +1. > > > > Regards, > > Mukul Kumar Singh > > > > >
