cbaenziger commented on a change in pull request #32: RATIS-667 Provide a visual for the LogService lifecycle URL: https://github.com/apache/incubator-ratis/pull/32#discussion_r319327133
########## File path: static/lifecycle.svg ########## @@ -0,0 +1,179 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" + "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd";> +<!-- Review comment: Nit: To build the SVG in the build script, would you want to use `sed -i` (OS X needs a bit of [finagling](https://unix.stackexchange.com/a/131940) for `sed -i`) to inject the license looking for the string `Generated by graphviz version` for now? Or I could write an XSLT to be a bit more pedantic if you'd like? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
