avijayanhwx commented on a change in pull request #76:
URL: https://github.com/apache/incubator-ratis/pull/76#discussion_r418187393
##########
File path:
ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricsReporting.java
##########
@@ -34,17 +34,41 @@ private MetricsReporting() {
}
public static Consumer<RatisMetricRegistry> consoleReporter(TimeDuration
rate) {
- return ratisMetricRegistry ->
ConsoleReporter.forRegistry(ratisMetricRegistry.getDropWizardMetricRegistry())
-
.convertRatesTo(TimeUnit.SECONDS).convertDurationsTo(TimeUnit.MILLISECONDS).build()
- .start(rate.getDuration(), rate.getUnit());
+ return ratisMetricRegistry -> {
+ ConsoleReporter reporter =
ConsoleReporter.forRegistry(ratisMetricRegistry.getDropWizardMetricRegistry())
+
.convertRatesTo(TimeUnit.SECONDS).convertDurationsTo(TimeUnit.MILLISECONDS).build();
+ reporter.start(rate.getDuration(), rate.getUnit());
+ ratisMetricRegistry.setConsoleReporter(reporter);
+ };
+ }
+
+ public static Consumer<RatisMetricRegistry> stopConsoleReporter() {
Review comment:
Do we need to add a stop method for every reporter? Maybe we can rely on
the generic close() method implemented by all reports (Closeable) and they
already call stop() in the close() method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
