runzhiwang opened a new pull request #92: URL: https://github.com/apache/incubator-ratis/pull/92
What's the problem ? shutdownGracefully in netty does not pass any parameter, then it will take the default parameter at [shutdownGracefully(DEFAULT_SHUTDOWN_QUIET_PERIOD, DEFAULT_SHUTDOWN_TIMEOUT, TimeUnit.SECONDS)](https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutorGroup.java#L70), the DEFAULT_SHUTDOWN_TIMEOUT is 15 seconds. So it must awaitTermination timeout, i.e. 1 second, now the timeout of bossGroup.awaitTermination and workerGroup.awaitTermination are both 1 second, so it need 2 seconds to closeImpl. It's too slow for test, and make test unstable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
