lokeshj1703 commented on a change in pull request #88:
URL: https://github.com/apache/incubator-ratis/pull/88#discussion_r421367469
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -222,6 +222,10 @@ private void increaseNextIndex(AppendEntriesRequestProto
request) {
}
}
+ private void increaseNextIndex(final long installedSnapshotIndex) {
+ getFollower().increaseNextIndex(installedSnapshotIndex + 1);
Review comment:
FollowerInfo#increaseNextIndex will throw error if current next index is
greater than installedSnapshotIndex + 1. I think we should do something like
updateCommitIndex where we set nextIndex to max value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
