runzhiwang edited a comment on pull request #97: URL: https://github.com/apache/incubator-ratis/pull/97#issuecomment-626658259
@bshashikant @avijayanhwx Could you help review this patch ? I think `GrpcServerMetrics `and `LogServiceMetricsRegistry `should extend `RatisMetrics`, then we do not need to define register and unregister in `GrpcServerMetrics `and `LogServiceMetricsRegistry`. If you agree, I will open another PR to refactor code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
