runzhiwang opened a new pull request #106:
URL: https://github.com/apache/incubator-ratis/pull/106


   What's the problem ?
   when create `RaftLogMetrics`, it use `memberId.getPeerId()` to identify, the 
`peerId` comes from `RaftServerProxy::getId`. So if one Ratis node belongs to 
different group, the `peerId` is same for different `RaftLogMetrics`. When 
create the second `RaftLogMetrics` for the second group, it will not create, 
because it's been created by the first group.
   
   How to fix ?
   `memberId.toString()` will return `peerId + "@" + groupId`.
   
   @bshashikant @lokeshj1703 Could you help review it ? Thank you very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to