dineshchitlangia commented on a change in pull request #103:
URL: https://github.com/apache/incubator-ratis/pull/103#discussion_r429327774
##########
File path:
ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java
##########
@@ -116,8 +116,6 @@ public void installSnapshot(StateMachine stateMachine,
LOG.warn("The snapshot md5 digest {} does not match expected {}",
digest, expectedDigest);
// rename the temp snapshot file to .corrupt
-// NativeIO.renameTo(tmpSnapshotFile, // TODO:
-// dir.getCorruptSnapshotFile(lastIncludedTerm,
lastIncludedIndex));
Review comment:
@arp7 good catch. These lines were commented out and since we are
removing the entire native library, I removed the commented line of code.
When I look at this piece again, I think that we can remove these NativeIO
line of code from the comment but add a TODO note regarding rename.
Would that be fine ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
