runzhiwang opened a new pull request #122:
URL: https://github.com/apache/incubator-ratis/pull/122


   ## What changes were proposed in this pull request?
   
   1. MetricsStateMachine is instance of DataApi, so data() return this, and 
data().flush call the method self, the dead recursion happens.
     default DataApi data() {
       return this instanceof DataApi? (DataApi)this : DataApi.DEFAULT;
     }
   2. assertCommitCount is a wrong unit test. @anshkhannasbu Could you explain 
why `stmCount + configCount + metaCount == expectedMsgs i.e. 2` ?  Sorry, I can 
not get you point.
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-975
   
   ## How was this patch tested?
   
   Existed tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to