GlenGeng commented on a change in pull request #150:
URL: https://github.com/apache/incubator-ratis/pull/150#discussion_r457018981
##########
File path:
ratis-test/src/test/java/org/apache/ratis/grpc/TestRetryCacheWithGrpc.java
##########
@@ -45,6 +47,11 @@
public void testRetryOnResourceUnavailableException()
throws InterruptedException, IOException {
RaftProperties properties = new RaftProperties();
+
+ // make sure leadership check won't affect the test
Review comment:
test cases invoking
`SimpleStateMachine4Testing::blockWriteStateMachineData()` or
`DelayLocalExecutionInjection::setDelayMs()` will be affected, which is meet
expectation. We need enlarge election timeout to make sure leader won't step
down before hearing append entries response from majority followers.
Another case is related to the membership change, especially the one with
9-servers. To avoid flaky behavior in CI environment, we need enlarge election
timeout a little bit, say from 300ms to 1s, since leader is vulnerable during
such situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
