----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4739/#review7014 -----------------------------------------------------------
I didn't see the patch attached to JIRA. We will need attached to the ticket in order to apply. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js <https://reviews.apache.org/r/4739/#comment15589> Are these necessary? If so, please complete. - mfranklin On 2012-04-18 18:15:28, Erin Noe-Payne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4739/ > ----------------------------------------------------------- > > (Updated 2012-04-18 18:15:28) > > > Review request for rave. > > > Summary > ------- > > Rave 547, 549, 550 > > Implement container.views.createElementForGadget to support > gadgets.views.openGadget, supporting slideout, modal, and dialog popups. > > > Diffs > ----- > > trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml PRE-CREATION > trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql > 1326730 > trunk/rave-portal-resources/src/main/webapp/css/default.css 1326730 > trunk/rave-portal-resources/src/main/webapp/script/rave.js 1326730 > trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js > 1326730 > > trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java > 1326730 > > Diff: https://reviews.apache.org/r/4739/diff > > > Testing > ------- > > > Thanks, > > Erin > >
