-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4813/#review7068
-----------------------------------------------------------



/branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
<https://reviews.apache.org/r/4813/#comment15680>

    Having this as a header causes the dropdown menu to appear over the below 
div's when in <980 px mode



/branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
<https://reviews.apache.org/r/4813/#comment15674>

    Any reason for the nested container-fluid?  I believe it should be taken 
off the header div



/branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
<https://reviews.apache.org/r/4813/#comment15678>

    On initial page load, Save and Cancel buttons are visible



/branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_person_profile.js
<https://reviews.apache.org/r/4813/#comment15675>

    Commented out code should simply be removed


- hilker.j


On 2012-04-20 13:15:13, Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4813/
> -----------------------------------------------------------
> 
> (Updated 2012-04-20 13:15:13)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> RAVE-564: Update the Person Profile page
> Added bootstrap tabs and form controls to profile.
> 
> 
> Diffs
> -----
> 
>   
> /branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/layouts/person_profile.jsp
>  1328116 
>   
> /branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
>  1328116 
>   
> /branches/bootstrap/rave-portal-resources/src/main/webapp/script/rave_person_profile.js
>  1328116 
> 
> Diff: https://reviews.apache.org/r/4813/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen
> 
>

Reply via email to