> On 2012-04-20 16:53:31, hilker.j wrote: > > /branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp, > > line 33 > > <https://reviews.apache.org/r/4831/diff/1/?file=103546#file103546line33> > > > > Should this be moved to > > \rave-portal-resources\src\main\webapp\WEB-INF\tags\third_party_js.tag?
I read up on modernizr and it appears to have a requirement to be loaded from the <head> - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4831/#review7071 ----------------------------------------------------------- On 2012-04-20 14:04:25, Kristen Legacy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4831/ > ----------------------------------------------------------- > > (Updated 2012-04-20 14:04:25) > > > Review request for rave. > > > Summary > ------- > > RAVE-567 Clean up implementation > Adding modernizr script and css modifications for ie & x-browser enhancements. > > > Diffs > ----- > > > /branches/bootstrap/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp > 1328116 > /branches/bootstrap/rave-portal-resources/src/main/webapp/css/default.css > 1328116 > /branches/bootstrap/rave-portal-resources/src/main/webapp/css/rave.css > 1328116 > > Diff: https://reviews.apache.org/r/4831/diff > > > Testing > ------- > > > Thanks, > > Kristen > >
