A patch is probably a difficult way to do a rename of a file. Review board might be having trouble figuring out what relates to what.
I don't have any issue with the rename. Why don't you roll it back for the patch and just request in the ticket that it gets renamed to navbar.tag. -Matt From: Chris Geer [mailto:[email protected]] Sent: Friday, April 27, 2012 1:18 PM To: [email protected] Subject: Re: Review Request: Separates the menubar from the page.jsp into a standalone jsp for easy customization I've made the changes I wanted and now I'm trying to resubmit the review but having a problem. One of the changes I made was I renamed the header.tag to navbar.tag since it better described what it really was. However, when I try and submit the review I get the following error from my patch file. The file '/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/navbar.tag' (r1331497) could not be found in the repository Any thoughts? Attached is the patch. Chris On Thu, Apr 26, 2012 at 8:25 AM, <[email protected]<mailto:[email protected]>> wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4880/#review7265 ----------------------------------------------------------- Thanks for the patch. A couple of issues though: 1) This only takes into account the portal pages. Menus on other pages are rendered differently. What would be the best approach is to have a single menubar with navigation contributions based on page template and render out the nav elements dynamically. This approach can then be extended to allow menu item contributions from other sources. 2) This needs a JIRA ticket for us to Apply it :) - mfranklin On 2012-04-25 23:47:10, Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4880/ > ----------------------------------------------------------- > > (Updated 2012-04-25 23:47:10) > > > Review request for rave. > > > Summary > ------- > > I pulled the "menubar" code out of page.jsp and put it into > common/menubar.jsp to support easier customization for users. I added an > optional attribute to the base-layout to support this additional field and > added it to the tile-def for standard pages. > > Something similar might be done for profile and store in the future but they > can't use this exact JSP since their menu options differ from normal pages. > > > Diffs > ----- > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/common/menubar.jsp > PRE-CREATION > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp > 1330602 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1330602 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1330602 > > Diff: https://reviews.apache.org/r/4880/diff > > > Testing > ------- > > Ran portal and witnessed no problems. > > > Thanks, > > Chris > >
