> On 2012-05-02 19:35:56, Raminder Singh wrote: > > You need to change the unit test also. Current unit test are broken after i > > applied the patch. Share a test gadget also if you have it hosted some > > place. > > Fernando Pinhati wrote: > I have a test gadget at: > http://mozart-gadgets.appspot.com/dev/friendslist.xml > I'm working on the unit tests.
I saw there are few more problems like rave API to populate Friend model etc. We may need to change getUniqueListOfConnectedPeople() also. I am going to dig little deeper to find Rave integration to social data. - Raminder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4965/#review7485 ----------------------------------------------------------- On 2012-05-04 17:15:00, Fernando Pinhati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4965/ > ----------------------------------------------------------- > > (Updated 2012-05-04 17:15:00) > > > Review request for rave. > > > Summary > ------- > > Issue: > https://issues.apache.org/jira/browse/RAVE-599 > > Fixed passing username instead of userId to PersonRepository findFriends > method. > > > Diffs > ----- > > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java > 1333183 > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/PersonServiceTest.java > 1333183 > > Diff: https://reviews.apache.org/r/4965/diff > > > Testing > ------- > > > Thanks, > > Fernando > >
